lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h
On Mon, Apr 15, 2019 at 09:37:23AM +0000, Anup Patel wrote:
> This patch adds SCAUSE interrupt flag and SCAUSE interrupt related
> defines to asm/csr.h. We also use these defines in kernel/irq.c and
> express SIE/SIP flags in-terms of SCAUSE interrupt causes.

I'm not a fan of this. For one this pollutes csr.h with bits not really
needed by most users, and it makes adding the M-mode nommu port which has
to use the M-mode causes much harder:

http://git.infradead.org/users/hch/misc.git/commitdiff/1221f5c32345ebe7ea2c1cd6e8a01ad4b422aaba

\
 
 \ /
  Last update: 2019-04-24 08:30    [W:0.095 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site