lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] spi: stm32: return the get_irq error
Date
On 4/24/19 2:38 PM, Fabien Dessenne wrote:
> During probe, return the "get_irq" error value instead of -ENOENT. This
> allows the driver to be defer probed if needed.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>

Acked-by: Amelie Delaunay <amelie.delaunay@st.com>

> ---
> drivers/spi/spi-stm32.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index 4186ed2..b222ce8 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -1839,8 +1839,9 @@ static int stm32_spi_probe(struct platform_device *pdev)
>
> spi->irq = platform_get_irq(pdev, 0);
> if (spi->irq <= 0) {
> - dev_err(&pdev->dev, "no irq: %d\n", spi->irq);
> - ret = -ENOENT;
> + ret = spi->irq;
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to get irq: %d\n", ret);
> goto err_master_put;
> }
> ret = devm_request_threaded_irq(&pdev->dev, spi->irq,
>
\
 
 \ /
  Last update: 2019-04-24 16:53    [W:0.060 / U:4.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site