lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/stm: ltdc: disable hw interrupts before its handler init
Le lun. 1 avr. 2019 à 11:19, Philippe CORNU <philippe.cornu@st.com> a écrit :
>
>
> On 3/29/19 4:48 PM, Yannick Fertré wrote:
> > Interrupt register must be disabled before call of
> > devm_request_threaded_irq function to avoid dummy interruption.
> >
> > Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> > ---
> > drivers/gpu/drm/stm/ltdc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..ef5b4d6 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -1118,6 +1118,10 @@ int ltdc_load(struct drm_device *ddev)
> > goto err;
> > }
> >
> > + /* Disable interrupts */
> > + reg_clear(ldev->regs, LTDC_IER,
> > + IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> > +
> > for (i = 0; i < MAX_IRQ; i++) {
> > irq = platform_get_irq(pdev, i);
> > if (irq < 0)
> > @@ -1138,10 +1142,6 @@ int ltdc_load(struct drm_device *ddev)
> > reset_control_deassert(rstc);
> > }
> >
> > - /* Disable interrupts */
> > - reg_clear(ldev->regs, LTDC_IER,
> > - IER_LIE | IER_RRIE | IER_FUIE | IER_TERRIE);
> > -
>
> Dear Yannick,
> Thank you for your patch,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>

Applied on drm-misc-next,
Thanks,
Benjamin

> Philippe :-)
>
> > ret = ltdc_get_caps(ddev);
> > if (ret) {
> > DRM_ERROR("hardware identifier (0x%08x) not supported!\n",
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

\
 
 \ /
  Last update: 2019-04-24 14:28    [W:0.029 / U:2.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site