lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools lib traceevent: Change tag string for error
On Wed, 24 Apr 2019 09:38:02 +0800
Leo Yan <leo.yan@linaro.org> wrote:

> The traceevnt lib is used by perf tool, when execute 'perf test -v 6' it
> outputs error log on ARM64 platform:
>
> running test 33 '*:*'trace-cmd: No such file or directory
>
> [...]
>
> trace-cmd: Invalid argument
>
> The trace event parsing code originally came from trace-cmd so it keeps
> the tag string "trace-cmd" for errors, this easily introduces the
> impression that perf tool launches trace-cmd command for trace event
> parsing, but in fact the related parsing is accomplished by traceevent
> lib.
>
> This patch changes the tag string to "libtraceevent" so can avoid
> confusion and let users to be more easily to connect the error with
> traceevent lib.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Arnaldo,

Can you pull this into your tree.

-- Steve

> ---
> tools/lib/traceevent/parse-utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/traceevent/parse-utils.c b/tools/lib/traceevent/parse-utils.c
> index 77e4ec6402dd..e99867111387 100644
> --- a/tools/lib/traceevent/parse-utils.c
> +++ b/tools/lib/traceevent/parse-utils.c
> @@ -14,7 +14,7 @@
> void __vwarning(const char *fmt, va_list ap)
> {
> if (errno)
> - perror("trace-cmd");
> + perror("libtraceevent");
> errno = 0;
>
> fprintf(stderr, " ");

\
 
 \ /
  Last update: 2019-04-24 14:09    [W:0.069 / U:4.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site