lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/komeda: Mark the local functions as static
On Wed, 24 Apr 2019 at 06:51, james qian wang (Arm Technology China)
<james.qian.wang@arm.com> wrote:
>
> Fix the kbuild test rebot reported warnings:
> - symbol was not declared. Should it be static?
> - missing braces around initializer
>
> Depends on:
> - https://patchwork.freedesktop.org/series/58976/
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: James (Qian) Wang <james.qian.wang@arm.com>
> ---
> .../gpu/drm/arm/display/komeda/d71/d71_component.c | 9 +++++----
> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 4 ++--
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4 +++-
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 +-
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c | 2 +-
> .../drm/arm/display/komeda/komeda_pipeline_state.c | 11 ++++++-----
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 10 ++++++----
> 7 files changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> index c56cfc2de147..031e5f305a3c 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
> @@ -391,7 +391,7 @@ static void d71_compiz_dump(struct komeda_component *c, struct seq_file *sf)
> seq_printf(sf, "CU_USER_HIGH:\t\t0x%X\n", v[1]);
> }
>
> -struct komeda_component_funcs d71_compiz_funcs = {
> +static struct komeda_component_funcs d71_compiz_funcs = {

Side note: Practically any piece of komeda_component_funcs and
komeda_pipeline_funcs could (and should) be constified.

-Emil

\
 
 \ /
  Last update: 2019-04-24 13:08    [W:0.068 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site