Messages in this thread Patch in this message | | | From | Kamlakant Patel <> | Subject | [PATCH] ipmi: fix slave-addr property add to ipmi platform device | Date | Wed, 24 Apr 2019 10:34:14 +0000 |
| |
Remove check for p->slave_addr while adding 'slave-addr' property entry since it can be 0. Currently, it throws following error: "ipmi_ssif dmi-ipmi-ssif.0: ipmi_ssif: device has no slave-addr property"
This patch fixes the issue.
Signed-off-by: Kamlakant Patel <kamlakantp@marvell.com> --- drivers/char/ipmi/ipmi_plat_data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_plat_data.c b/drivers/char/ipmi/ipmi_plat_data.c index 8f0ca2a..2b62104 100644 --- a/drivers/char/ipmi/ipmi_plat_data.c +++ b/drivers/char/ipmi/ipmi_plat_data.c @@ -34,8 +34,7 @@ struct platform_device *ipmi_platform_add(const char *name, unsigned int inst, p->regspacing = p->regsize; pr[pidx++] = PROPERTY_ENTRY_U8("ipmi-type", p->type); - if (p->slave_addr) - pr[pidx++] = PROPERTY_ENTRY_U8("slave-addr", p->slave_addr); + pr[pidx++] = PROPERTY_ENTRY_U8("slave-addr", p->slave_addr); pr[pidx++] = PROPERTY_ENTRY_U8("addr-source", p->addr_source); if (p->regshift) pr[pidx++] = PROPERTY_ENTRY_U8("reg-shift", p->regshift); -- 1.8.3.1
| |