lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove
From
Date
On 24/04/2019 07:11, Jiada Wang wrote:
> Currently IRQ remains enabled after .remove, later if device is probed,
> IRQ is requested before .thermal_init, this may cause IRQ function be
> called before device is initialized.
>
> this patch disables interrupt in .remove, to ensure irq function
> only be called after device is fully initialized.
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>

Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---
> drivers/thermal/rcar_gen3_thermal.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
> index 065e16f53285..280230951dfe 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -307,6 +307,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
> static int rcar_gen3_thermal_remove(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);
> +
> + rcar_thermal_irq_set(priv, false);
>
> pm_runtime_put(dev);
> pm_runtime_disable(dev);
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

\
 
 \ /
  Last update: 2019-04-24 11:38    [W:0.209 / U:8.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site