lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 02/19] net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option
From
Date


On 24.04.19 03:27, Jakub Kicinski wrote:
> On Tue, 23 Apr 2019 16:08:53 +0300, Grygorii Strashko wrote:
>> Both drivers CPSW and EMAC can't work without CPDMA, hence simplify build
>> of those drivers by always linking davinci_cpdma and drop TI_DAVINCI_CPDMA
>> config option.
>> Note. the davinci_emac driver module was changed to "ti_davinci_emac" to
>> make build work.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Last time I tried including the same object file in two different
> modules it backfired pretty badly. Would you mind sparing some
> details as to why you need to do this?

I've tried it as modules and inbuid and see no issues.
Issue with build happens if EXPORT_SYMBOL_GPL() not removed.

It's not expected and not supported to load more then one TI Net
driver at same hw, so modules also are just be loaded fine.

Why? It's to get rid of CONFIG options which were historically added,
but are not required now (and even can't be disabled of if disabled will
cause build failures) - result simplified build/Kconfig and code.


--
Best regards,
grygorii

\
 
 \ /
  Last update: 2019-04-24 11:31    [W:0.072 / U:0.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site