lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] dmaengine: stm32-dma: dmaengine: stm32-dma: use platform_get_irq()
    Date
    platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
    requesting IRQ's resources, as they can be not ready yet. Using
    platform_get_irq() instead is preferred for getting IRQ even if it was
    not retrieved earlier.

    Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
    ---
    drivers/dma/stm32-dma.c | 11 ++++++-----
    1 file changed, 6 insertions(+), 5 deletions(-)

    diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
    index ba239b5..3306818 100644
    --- a/drivers/dma/stm32-dma.c
    +++ b/drivers/dma/stm32-dma.c
    @@ -1302,13 +1302,14 @@ static int stm32_dma_probe(struct platform_device *pdev)

    for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) {
    chan = &dmadev->chan[i];
    - res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
    - if (!res) {
    - ret = -EINVAL;
    - dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
    + chan->irq = platform_get_irq(pdev, i);
    + if (chan->irq < 0) {
    + ret = chan->irq;
    + if (ret != -EPROBE_DEFER)
    + dev_err(&pdev->dev,
    + "No irq resource for chan %d\n", i);
    goto err_unregister;
    }
    - chan->irq = res->start;
    ret = devm_request_irq(&pdev->dev, chan->irq,
    stm32_dma_chan_irq, 0,
    dev_name(chan2dev(chan)), chan);
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-04-24 11:23    [W:3.406 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site