lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soc: imx: Fix build error without CONFIG_SOC_BUS
From
Date
On 2019/4/24 16:11, Leonard Crestez wrote:
> On 4/24/2019 11:00 AM, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> During randconfig builds, I occasionally run into an invalid configuration
>>
>> drivers/soc/imx/soc-imx8.o: In function `imx8_soc_init':
>> soc-imx8.c:(.init.text+0x144): undefined reference to `soc_device_register'
>>
>> while CONFIG_SOC_BUS is not set, the building failed like this. This patch
>> selects SOC_BUS to fix it.
>>
>> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
>> @@ -5,6 +5,7 @@ config IMX_GPCV2_PM_DOMAINS
>> depends on ARCH_MXC || (COMPILE_TEST && OF)
>> depends on PM
>> select PM_GENERIC_DOMAINS
>> + select SOC_BUS
>> default y if SOC_IMX7D
>
> You should "select SOC_BUS" from "config ARCH_MXC" in arm64
> Kconfig.platforms, not from a power domain implementation.
>
> Your patch works because arm64 ARCH_MXC currently does "select
> IMX_GPCV2_PM_DOMAINS" but it's silly to use this intermediary.

Yes, you are right, thanks!

>
> --
> Regards,
> Leonard
>
>

\
 
 \ /
  Last update: 2019-04-24 10:48    [W:0.077 / U:1.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site