lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v2 11/17] sched: Basic tracking of matching tasks
From
Date
On 4/24/19 1:43 PM, Vineeth Remanan Pillai wrote:
>> A minor nitpick. I find keeping the vruntime base readjustment in
>> core_prio_less probably is more straight forward rather than pass a
>> core_cmp bool around.
>
> The reason I moved the vruntime base adjustment to __prio_less is
> because, the vruntime seemed alien to __prio_less when looked as
> a standalone function.

Doing the adjustment in core_prio_less
will save us an extra "if" comparison. I'm fine either way.

Thx.

Tim

>
> I do not have a strong opinion on both. Probably a better approach
> would be to replace both cpu_prio_less/core_prio_less with prio_less
> which takes the third arguement 'bool on_same_rq'?
>
> Thanks
>

\
 
 \ /
  Last update: 2019-04-25 00:13    [W:0.134 / U:7.348 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site