lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC][PATCH 4/5] mips/atomic: Fix smp_mb__{before,after}_atomic()
Date
Hi Peter,

On Wed, Apr 24, 2019 at 02:37:00PM +0200, Peter Zijlstra wrote:
> --- a/arch/mips/include/asm/barrier.h
> +++ b/arch/mips/include/asm/barrier.h
> @@ -230,9 +238,6 @@
> #define nudge_writes() mb()
> #endif
>
> -#define __smp_mb__before_atomic() __smp_mb__before_llsc()
> -#define __smp_mb__after_atomic() smp_llsc_mb()
> -
> /*
> * Some Loongson 3 CPUs have a bug wherein execution of a memory access (load,
> * store or pref) in between an ll & sc can cause the sc instruction to

I think this bit should be part of patch 3, where you currently add a
second definition of these 2 macros.

Otherwise this one looks reasonable to me.

Thanks,
Paul

\
 
 \ /
  Last update: 2019-04-24 23:24    [W:0.091 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site