lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 24/25] drm: kirin: Pass driver data to crtc init and plane init
On Wed, Apr 24, 2019 at 10:09 AM Sam Ravnborg <sam@ravnborg.org> wrote:
> On Tue, Apr 23, 2019 at 04:20:55PM -0700, John Stultz wrote:
> > static int kirin_drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
> > - struct drm_plane *plane)
> > + struct drm_plane *plane,
> > + const struct kirin_drm_data *driver_data)
>
> Indent looks wrong here.
>
..
> > ret = drm_universal_plane_init(dev, &kplane->base, 1,
> > + driver_data->plane_funcs,
> > + driver_data->channel_formats,
> > + driver_data->channel_formats_cnt,
> > + NULL, type, NULL);
> Indent looks wrong here.

Thanks! I've now fixed those up.

> I missed where ade_driver_data came from.
> This looks an extra patch to intoduce driver_data,
> that maybe should be merged with an earlier version?

I'm not sure I'm following you here. Can you clarify a bit more?

thanks
-john

\
 
 \ /
  Last update: 2019-04-24 21:35    [W:0.065 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site