Messages in this thread | | | Subject | Re: [PATCH RFC 4/8] soc: samsung: Add Exynos Adaptive Supply Voltage driver | From | Sylwester Nawrocki <> | Date | Wed, 24 Apr 2019 10:11:07 +0200 |
| |
On 4/23/19 12:50, Krzysztof Kozlowski wrote: >> +static int exynos5422_asv_get_table(void) >> +{ >> + unsigned int reg = exynos_chipid_read(EXYNOS_CHIPID_REG_PKG_ID); > > One more thought: you read this register multiple times in the same > function. I think it is not needed - just read once, store the value > and use the helpers to parse it.
Yes, I have noticed that as well. I'm not sure though if it is worth to additionally cache registers manually like this when we use the regmap. I have already converted that code to use the regmap API for v2. And these are barely few registers reads at the driver initialization time, not any hot path.
-- Thanks, Sylwester
| |