lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 016/115] mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue
    Date
    From: Ido Schimmel <idosch@mellanox.com>

    [ Upstream commit a8c133b06183c529c51cd0d54eb57d6b7078370c ]

    The EMAD workqueue is used to handle retransmission of EMAD packets that
    contain configuration data for the device's firmware.

    Given the workers need to allocate these packets and that the code is
    not called as part of memory reclaim path, remove the WQ_MEM_RECLAIM
    flag.

    Fixes: d965465b60ba ("mlxsw: core: Fix possible deadlock")
    Signed-off-by: Ido Schimmel <idosch@mellanox.com>
    Acked-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlxsw/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mellanox/mlxsw/core.c
    +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
    @@ -568,7 +568,7 @@ static int mlxsw_emad_init(struct mlxsw_
    if (!(mlxsw_core->bus->features & MLXSW_BUS_F_TXRX))
    return 0;

    - emad_wq = alloc_workqueue("mlxsw_core_emad", WQ_MEM_RECLAIM, 0);
    + emad_wq = alloc_workqueue("mlxsw_core_emad", 0, 0);
    if (!emad_wq)
    return -ENOMEM;
    mlxsw_core->emad_wq = emad_wq;

    \
     
     \ /
      Last update: 2019-04-24 19:45    [W:4.092 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site