lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v1] Bluetooth: hci_core: Don't stop BT if the BD address missing in dts
Hi Harish,

On 2019-04-24 12:34, Harish Bandi wrote:
> Hi Balakrishna,
>
> On 2019-04-23 22:05, Marcel Holtmann wrote:
>> Hi Balakrishna,
>>
>>> When flag HCI_QUIRK_USE_BDADDR_PROPERTY is set, we will read the
>>> bluetooth address from dts. If the bluetooth address node is missing
>>> from the dts we will enable it controller UNCONFIGURED state.
>>> This patch enables the normal flow even if the BD address is missing
>>> from the dts tree.
>>>
>>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>>> ---
>>> net/bluetooth/hci_core.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>
>> can I get an ACK for this one?
>>
>> Regards
>>
>> Marcel
>
> nit: it would be better if we print error message, if bd address
> missing in dts.
>
> tested 20 times with bd address missing in dts.
> tested 20 times with bd address available in dts.
>
> Tested-by: Harish Bandi <c-hbandi@codeaurora.org>
>
>
> Thanks,
> Harish

Thanks for testing will note this improvement and send an incremental
patch.

--
Regards
Balakrishna.

\
 
 \ /
  Last update: 2019-04-24 09:09    [W:0.078 / U:4.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site