Messages in this thread | | | From | Greentime Hu <> | Date | Wed, 24 Apr 2019 14:56:39 +0800 | Subject | Re: [PATCH] nds32: vdso: drop unnecessary cc-ldoption |
| |
Hi Nick & Yamada,
Nick Desaulniers <ndesaulniers@google.com> 於 2019年4月24日 週三 上午5:19寫道: > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > of binutils for the kernel according to > Documentation/process/changes.rst is 2.20. > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > Cc: clang-built-linux@googlegroups.com > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/nds32/kernel/vdso/Makefile | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile > index e6c50a701313..d379645cad74 100644 > --- a/arch/nds32/kernel/vdso/Makefile > +++ b/arch/nds32/kernel/vdso/Makefile > @@ -11,10 +11,8 @@ obj-vdso := note.o datapage.o sigreturn.o gettimeofday.o > targets := $(obj-vdso) vdso.so vdso.so.dbg > obj-vdso := $(addprefix $(obj)/, $(obj-vdso)) > > -ccflags-y := -shared -fno-common -fno-builtin > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso.so.1 \ > - $(call cc-ldoption, -Wl$(comma)--hash-style=sysv) > -ccflags-y += -fPIC -Wl,-shared -g > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib -fPIC -Wl,-shared -g \ > + -Wl,-soname=linux-vdso.so.1 -Wl,--hash-style=sysv > > # Disable gcov profiling for VDSO code > GCOV_PROFILE := n
Thank you. Acked-by: Greentime Hu <greentime@andestech.com>
| |