Messages in this thread | | | Date | Tue, 23 Apr 2019 12:10:50 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation |
| |
On Tue, Apr 23, 2019 at 09:33:53AM -0500, Alex G wrote: > On 4/22/19 7:33 PM, Alex Williamson wrote: > > There is nothing wrong happening here that needs to fill logs. I > > thought maybe if I enabled notification of autonomous bandwidth > > changes that it might categorize these as something we could > > ignore, but it doesn't. How can we identify only cases where this > > is an erroneous/noteworthy situation? Thanks, > > You don't. Ethernet doesn't. USB doesn't. This logging behavior is > consistent with every other subsystem that deals with multi-speed links.
Can you point me to the logging in these other subsystems so I can learn more about how they deal with this?
I agree that emitting log messages for normal and expected events will lead to user confusion and we need to do something.
e8303bb7a75c ("PCI/LINK: Report degraded links via link bandwidth notification") was merged in v5.1-rc1, so we still have (a little) time to figure this out before v5.1.
Bjorn
| |