Messages in this thread | | | Subject | Re: [PATCH v12 07/31] mm: make pte_unmap_same compatible with SPF | From | Laurent Dufour <> | Date | Tue, 23 Apr 2019 17:47:53 +0200 |
| |
Le 23/04/2019 à 17:43, Matthew Wilcox a écrit : > On Tue, Apr 16, 2019 at 03:44:58PM +0200, Laurent Dufour wrote: >> +static inline vm_fault_t pte_unmap_same(struct vm_fault *vmf) >> { >> - int same = 1; >> + int ret = 0; > > Surely 'ret' should be of type vm_fault_t?
Nice catch !
> >> + ret = VM_FAULT_RETRY; > > ... this should have thrown a sparse warning?
It should have, but I can't remember having see it, weird...
| |