lkml.org 
[lkml]   [2019]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] memstick: mark expected switch fall-throughs
From
Date


On 4/23/19 10:15 AM, Kees Cook wrote:
> On Tue, Feb 12, 2019 at 6:57 PM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/memstick/host/jmb38x_ms.c: In function ‘jmb38x_ms_write_data’:
>> drivers/memstick/host/jmb38x_ms.c:261:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/jmb38x_ms.c:262:2: note: here
>> case 2:
>> ^~~~
>> drivers/memstick/host/jmb38x_ms.c:264:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/jmb38x_ms.c:265:2: note: here
>> case 1:
>> ^~~~
>> drivers/memstick/host/tifm_ms.c: In function ‘tifm_ms_write_data’:
>> drivers/memstick/host/tifm_ms.c:168:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/tifm_ms.c:169:2: note: here
>> case 2:
>> ^~~~
>> drivers/memstick/host/tifm_ms.c:171:15: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> host->io_pos++;
>> ~~~~~~~~~~~~^~
>> drivers/memstick/host/tifm_ms.c:172:2: note: here
>> case 1:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>

Thanks, Kees!

--
Gustavo

\
 
 \ /
  Last update: 2019-04-23 17:25    [W:0.086 / U:8.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site