Messages in this thread | | | From | Vitor Soares <> | Subject | RE: [PATCH 1/3] remap: Add I3C bus support | Date | Tue, 23 Apr 2019 14:58:06 +0000 |
| |
Hi Mark,
From: Mark Brown <broonie@kernel.org> Date: Tue, Apr 16, 2019 at 16:39:48
> On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote: > > > +++ b/drivers/base/regmap/regmap-i3c.c > > @@ -0,0 +1,62 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates. > > Please make the entire header C++ style so it looks more consistent. > Otherwise this looks good modulo
I will change it next drop.
> Boris' comment; I'm fine with leaving > extra modes for later so long as they can be introduced without > disrupting existing users so the only question there would be if we > should name the init function in some way that's specific to the I/O > mode being used here.
My concern is that booth modes (SDR/HDR) might be needed on the device. e.g. use SDR to configure the device and use HDR to send/receive large data.
Best regards, Vitor Soares
| |