Messages in this thread | | | From | weizhenliang <> | Subject | Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit | Date | Tue, 23 Apr 2019 14:13:00 +0000 |
| |
On 04/23, Oleg wrote: >On 04/23, weizhenliang wrote: >> >> Last time Oleg suggested using SIG_DFL as the third parameter, but its type is 'void (*)(int)', but not expected 'struct k_sigaction *'. > >Yes I misread the signature of TRACE_EVENT(signal_deliver), and I thought you at least compiled the kernel with your patch applied ;) > >> How about >> trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, &sighand->action[signr >> - 1]); ? > >sure, this should fix the problem.
Sorry about that, I will pay more attention to it in the future. And thanks for your reply, I will re-adjust the patch later.
Wei.
| |