lkml.org 
[lkml]   [2019]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v3] signal: trace_signal_deliver when signal_group_exit
On Tue, Apr 23, 2019 at 01:10:52PM +0000, weizhenliang wrote:
> On Mon, Apr 22, 2019 at 11:25 PM Oleg Nesterov <oleg@redhat.com> wrote:
> >On 04/22, Zhenliang Wei wrote:
> >>
> >> --- a/kernel/signal.c
> >> +++ b/kernel/signal.c
> >> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig)
> >> if (signal_group_exit(signal)) {
> >> ksig->info.si_signo = signr = SIGKILL;
> >> sigdelset(&current->pending.signal, SIGKILL);
> >> + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL);
> >> recalc_sigpending();
> >> goto fatal;
> >> }
> >
> >Reviewed-by: Oleg Nesterov <oleg@redhat.com>
>
> Last time Oleg suggested using SIG_DFL as the third parameter, but its type is 'void (*)(int)', but not expected 'struct k_sigaction *'.

Sigh, I should've caught that in the first commit.
Although it suggests you didn't even compile your patch...

>
> How about
> trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, &sighand->action[signr - 1]);
> ?

That should work, yes.

Christian

\
 
 \ /
  Last update: 2019-04-23 15:34    [W:0.027 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site