Messages in this thread | | | From | weizhenliang <> | Subject | Re: [PATCH v3] signal: trace_signal_deliver when signal_group_exit | Date | Tue, 23 Apr 2019 13:10:52 +0000 |
| |
On Mon, Apr 22, 2019 at 11:25 PM Oleg Nesterov <oleg@redhat.com> wrote: >On 04/22, Zhenliang Wei wrote: >> >> --- a/kernel/signal.c >> +++ b/kernel/signal.c >> @@ -2441,6 +2441,7 @@ bool get_signal(struct ksignal *ksig) >> if (signal_group_exit(signal)) { >> ksig->info.si_signo = signr = SIGKILL; >> sigdelset(¤t->pending.signal, SIGKILL); >> + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL); >> recalc_sigpending(); >> goto fatal; >> } > >Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Last time Oleg suggested using SIG_DFL as the third parameter, but its type is 'void (*)(int)', but not expected 'struct k_sigaction *'.
How about trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, &sighand->action[signr - 1]); ?
Although we know that action[SIGKILL] must be SIG_DFL, in order to adapt to the parameter type, I suggest to use the original variable value.
Zhenliang Wei.
| |