lkml.org 
[lkml]   [2019]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 4.14 35/43] tty: fix NULL pointer issue when tty_port ops is not set
Hi Sasha,

On Mon, Apr 22, 2019 at 03:47:19PM -0400, Sasha Levin wrote:
> From: Fabien Dessenne <fabien.dessenne@st.com>
>
> [ Upstream commit f4e68d58cf2b20a581759bbc7228052534652673 ]
>
> Unlike 'client_ops' which is initialized to 'default_client_ops', the
> port operations 'ops' may be left to NULL.
> Check the 'ops' value before checking the 'ops->x' value.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>

Despite the commit message, this one doesn't really fix anything and has
been reverted in Greg's tree (not sure why hasn't shown up in linux-next
yet).

Johan

\
 
 \ /
  Last update: 2019-04-23 07:37    [W:0.300 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site