Messages in this thread | | | Date | Tue, 23 Apr 2019 18:44:33 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net v4] net/ncsi: handle overflow when incrementing mac address |
| |
On Wed, 24 Apr 2019 01:43:32 +0000, Tao Ren wrote: > Previously BMC's MAC address is calculated by simply adding 1 to the > last byte of network controller's MAC address, and it produces incorrect > result when network controller's MAC address ends with 0xFF. > > The problem can be fixed by calling eth_addr_inc() function to increment > MAC address; besides, the MAC address is also validated before assigning > to BMC. > > Fixes: cb10c7c0dfd9 ("net/ncsi: Add NCSI Broadcom OEM command") > Signed-off-by: Tao Ren <taoren@fb.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
| |