[lkml]   [2019]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net 1/2] net: add eth_addr_inc in etherdevice.h
On Wed, 24 Apr 2019 00:59:52 +0000, Tao Ren wrote:
> > Please see: Documentation/doc-guide/kernel-doc.rst
> >
> > Here we need:
> > - "()" after function name;
> > - no extra line between function name and argument description.
> Thank you for pointing it out (I didn't know the doc-guide). Given I copied the function comment from eth_addr_dec(), I will also fix the format for eth_addr_eth() then.
> BTW, "()" is missing from all the other functions' comment in etherdevice.h, so maybe we should fix that in a separate patch?

Possibly, I'm just trying to make sure the new stuff we add follows the
official guidelines :) For the old stuff we need to way it with
potential merge conflicts and muddied git history so the case is not as
clear cut.

 \ /
  Last update: 2019-04-24 03:26    [W:0.038 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site