Messages in this thread | | | Date | Wed, 24 Apr 2019 11:12:59 +1000 | From | Stephen Rothwell <> | Subject | Re: linux-next: Signed-off-by missing for commit in the drm tree |
| |
Hi Deepak,
On Wed, 24 Apr 2019 00:36:19 +0000 Deepak Singh Rawat <drawat@vmware.com> wrote: > > On Wed, 2019-04-24 at 10:22 +1000, Stephen Rothwell wrote: > > > > Commit > > > > a9f58c456e9d ("drm/vmwgfx: Be more restrictive when dirtying > > resources") > > Actully the Signed-off-by: is not missing see > > https://cgit.freedesktop.org/drm/drm/commit/drivers/gpu/drm/vmwgfx?id=a9f58c456e9dde6f272e7be4d6bed607fd7008aa
There is no Signed-off-by from you as the committer (just a Reviewed-by from you and a Signed-off-by from the author).
> By the way there is the patter "---" before Signed-off-by:(which is > same as used by patch to separate description from code) and I think > the script is reading only till that point. I think "---" should not be > used in patch description.
All the tags should be *before* the "-- " or "---" separator.
-- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] | |