lkml.org 
[lkml]   [2019]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] dt-bindings: adc: mt8183: add binding document
From
Date
On Tue, 2019-04-23 at 16:35 +0200, Matthias Brugger wrote:
>
> On 22/04/2019 13:54, Zhiyong Tao wrote:
> > The commit adds mt8183 compatible node in binding document.
> >
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > index 0df9befdaecc..05bc79d8483c 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> > @@ -15,6 +15,7 @@ Required properties:
> > - "mediatek,mt2712-auxadc": For MT2712 family of SoCs
> > - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
> > - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
> > + - "mediatek,mt8183-auxadc": For MT8183 family of SoCs
> > - reg: Address range of the AUXADC unit.
> > - clocks: Should contain a clock specifier for each entry in clock-names
> > - clock-names: Should contain "main".
> >
>
> You are missing the logic in the driver to bind against this compatible.
> If there is nothing different from other SoCs then you could add a compatible
> with a fallback, like:
>
> "mediatek,mt8183-auxadc", "mediatek,mt7622-auxadc": For MT8183 family of SoCs

==> Thanks for your suggestion. In v2, we will add the comment here:
- "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family
of SoCs.

>
> Regards,
> Matthias


\
 
 \ /
  Last update: 2019-04-24 02:52    [W:0.047 / U:1.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site