Messages in this thread | | | Date | Tue, 23 Apr 2019 15:37:54 -0500 | From | Josh Poimboeuf <> | Subject | Re: [RFC 5/6] arm64: sleep: Add stack frame setup for __cpu_supsend_enter |
| |
In $SUBJECT, s/supsend/suspend/.
On Tue, Apr 09, 2019 at 02:52:42PM +0100, Raphael Gault wrote: > Annotate cpu_resume and _cpu_resume to silence objtool warning > about non-standard stack frame. > > Signed-off-by: Raphael Gault <raphael.gault@arm.com> > --- > arch/arm64/kernel/sleep.S | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/kernel/sleep.S b/arch/arm64/kernel/sleep.S > index 3e53ffa07994..eb434525fe82 100644 > --- a/arch/arm64/kernel/sleep.S > +++ b/arch/arm64/kernel/sleep.S > @@ -90,6 +90,7 @@ ENTRY(__cpu_suspend_enter) > str x0, [x1] > add x0, x0, #SLEEP_STACK_DATA_SYSTEM_REGS > stp x29, lr, [sp, #-16]! > + mov x29, sp
Why is it changing the actual code? The patch description indicates that it's only adding annotations.
> bl cpu_do_suspend > ldp x29, lr, [sp], #16 > mov x0, #1 > @@ -146,3 +147,6 @@ ENTRY(_cpu_resume) > mov x0, #0 > ret > ENDPROC(_cpu_resume) > + > + asm_stack_frame_non_standard cpu_resume > + asm_stack_frame_non_standard _cpu_resume > -- > 2.17.1 >
-- Josh
| |