lkml.org 
[lkml]   [2019]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 07/10] iommu/vt-d: Keep swiotlb on if bounce page is necessary
From
Date
Hi,

On 4/23/19 12:47 AM, Christoph Hellwig wrote:
> On Sun, Apr 21, 2019 at 09:17:16AM +0800, Lu Baolu wrote:
>> +static inline bool platform_has_untrusted_device(void)
>> {
>> + bool has_untrusted_device = false;
>> struct pci_dev *pdev = NULL;
>>
>> for_each_pci_dev(pdev) {
>> if (pdev->untrusted) {
>> + has_untrusted_device = true;
>> break;
>> }
>> }
>>
>> + return has_untrusted_device;
>
> This shouldn't really be in the intel-iommu driver, should it?
> This probably should be something like pci_has_untrusted_devices
> and be moved to the PCI code.
>

Fair enough.

Best regards,
Lu Baolu

\
 
 \ /
  Last update: 2019-04-23 04:07    [W:0.048 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site