lkml.org 
[lkml]   [2019]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectlinux-next: build warning after merge of the net-next tree
Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

net/socket.c: In function 'sock_ioctl':
net/socket.c:1173:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
err = sock->ops->gettstamp(sock, argp,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmd == SIOCGSTAMP_OLD,
~~~~~~~~~~~~~~~~~~~~~~
!IS_ENABLED(CONFIG_64BIT));
~~~~~~~~~~~~~~~~~~~~~~~~~~
net/socket.c:1176:3: note: here
case SIOCGSTAMP_NEW:
^~~~

Introduced by commit

0768e17073dc ("net: socket: implement 64-bit timestamps")

I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early. The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).

--
Cheers,
Stephen Rothwell
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-04-23 03:33    [W:0.027 / U:4.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site