lkml.org 
[lkml]   [2019]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.0 14/98] staging: axis-fifo: add CONFIG_OF dependency
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit 1beea6204e2304dd11600791d8dad8e7350af6ad ]

    When building without CONFIG_OF, the compiler loses track of the flow
    control in axis_fifo_probe(), and thinks that many variables are used
    without an initialization even though we actually leave the function
    before the first use:

    drivers/staging/axis-fifo/axis-fifo.c: In function 'axis_fifo_probe':
    drivers/staging/axis-fifo/axis-fifo.c:900:5: error: 'rxd_tdata_width' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    if (rxd_tdata_width != 32) {
    ^
    drivers/staging/axis-fifo/axis-fifo.c:907:5: error: 'txd_tdata_width' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    if (txd_tdata_width != 32) {
    ^
    drivers/staging/axis-fifo/axis-fifo.c:914:5: error: 'has_tdest' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    if (has_tdest) {
    ^
    drivers/staging/axis-fifo/axis-fifo.c:919:5: error: 'has_tid' may be used uninitialized in this function [-Werror=maybe-uninitialized]

    When CONFIG_OF is set, this does not happen, and since the driver cannot
    work without it, just add that option as a Kconfig dependency.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
    ---
    drivers/staging/axis-fifo/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/staging/axis-fifo/Kconfig b/drivers/staging/axis-fifo/Kconfig
    index 687537203d9c..d9725888af6f 100644
    --- a/drivers/staging/axis-fifo/Kconfig
    +++ b/drivers/staging/axis-fifo/Kconfig
    @@ -3,6 +3,7 @@
    #
    config XIL_AXIS_FIFO
    tristate "Xilinx AXI-Stream FIFO IP core driver"
    + depends on OF
    default n
    help
    This adds support for the Xilinx AXI-Stream
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-04-22 22:11    [W:6.034 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site