lkml.org 
[lkml]   [2019]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 28/43] net: ethernet: ti: fix possible object reference leak
    Date
    From: Wen Yang <wen.yang99@zte.com.cn>

    [ Upstream commit 75eac7b5f68b0a0671e795ac636457ee27cc11d8 ]

    The call to of_get_child_by_name returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with the following warnings:
    ./drivers/net/ethernet/ti/netcp_ethss.c:3661:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
    ./drivers/net/ethernet/ti/netcp_ethss.c:3665:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: Wingman Kwok <w-kwok2@ti.com>
    Cc: Murali Karicheri <m-karicheri2@ti.com>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: netdev@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
    ---
    drivers/net/ethernet/ti/netcp_ethss.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c
    index 28cb38af1a34..ff7a71ca0b13 100644
    --- a/drivers/net/ethernet/ti/netcp_ethss.c
    +++ b/drivers/net/ethernet/ti/netcp_ethss.c
    @@ -3538,12 +3538,16 @@ static int gbe_probe(struct netcp_device *netcp_device, struct device *dev,

    ret = netcp_txpipe_init(&gbe_dev->tx_pipe, netcp_device,
    gbe_dev->dma_chan_name, gbe_dev->tx_queue_id);
    - if (ret)
    + if (ret) {
    + of_node_put(interfaces);
    return ret;
    + }

    ret = netcp_txpipe_open(&gbe_dev->tx_pipe);
    - if (ret)
    + if (ret) {
    + of_node_put(interfaces);
    return ret;
    + }

    /* Create network interfaces */
    INIT_LIST_HEAD(&gbe_dev->gbe_intf_head);
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-04-22 21:58    [W:4.314 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site