lkml.org 
[lkml]   [2019]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 3.18 01/15] qlcnic: Avoid potential NULL pointer dereference
    Date
    From: Aditya Pakki <pakki001@umn.edu>

    [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ]

    netdev_alloc_skb can fail and return a NULL pointer which is
    dereferenced without a check. The patch avoids such a scenario.

    Signed-off-by: Aditya Pakki <pakki001@umn.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
    index 0a2318cad34d..63ebc491057b 100644
    --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
    +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
    @@ -1038,6 +1038,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode)

    for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) {
    skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE);
    + if (!skb)
    + break;
    qlcnic_create_loopback_buff(skb->data, adapter->mac_addr);
    skb_put(skb, QLCNIC_ILB_PKT_SIZE);
    adapter->ahw->diag_cnt = 0;
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-04-22 21:52    [W:3.643 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site