Messages in this thread Patch in this message | | | Date | Mon, 22 Apr 2019 11:27:11 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH] kdb: kdb_io: Replace strcpy() by strscpy() |
| |
The strcpy() function is being deprecated. Replace it by the safer strscpy() and fix the following Coverity warning:
"You might overrun the 256-character fixed-size string kdb_buffer by copying cphold without checking the length."
Addresses-Coverity-ID: 138996 ("Copy into fixed size buffer") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- kernel/debug/kdb/kdb_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 6a4b41484afe..ebc4aa2d0737 100644 --- a/kernel/debug/kdb/kdb_io.c +++ b/kernel/debug/kdb/kdb_io.c @@ -836,7 +836,7 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap) */ if (kdb_grepping_flag && !suspend_grep) { *cphold = replaced_byte; - strcpy(kdb_buffer, cphold); + strscpy(kdb_buffer, cphold, sizeof(kdb_buffer)); len = strlen(kdb_buffer); next_avail = kdb_buffer + len; size_avail = sizeof(kdb_buffer) - len; -- 2.21.0
| |