Messages in this thread Patch in this message | | | Date | Mon, 22 Apr 2019 11:21:06 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH] kdb: kdb_support: replace strcpy() by strscpy() |
| |
The strcpy() function is being deprecated. Replace it by the safer strscpy() and fix the following Coverity warning:
"You might overrun the 129-character fixed-size string ks_namebuf by copying name without checking the length."
Addresses-Coverity-ID: 138995 ("Copy into fixed size buffer") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- kernel/debug/kdb/kdb_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c index 50bf9b119bad..b8e6306e7e13 100644 --- a/kernel/debug/kdb/kdb_support.c +++ b/kernel/debug/kdb/kdb_support.c @@ -192,7 +192,7 @@ int kallsyms_symbol_complete(char *prefix_name, int max_len) while ((name = kdb_walk_kallsyms(&pos))) { if (strncmp(name, prefix_name, prefix_len) == 0) { - strcpy(ks_namebuf, name); + strscpy(ks_namebuf, name, sizeof(ks_namebuf)); /* Work out the longest name that matches the prefix */ if (++number == 1) { prev_len = min_t(int, max_len-1, -- 2.21.0
| |