Messages in this thread | | | Date | Mon, 22 Apr 2019 09:25:31 -0400 | From | Sasha Levin <> | Subject | Re: [GIT PULL] Hyper-V commits for 5.1 |
| |
ping?
On Wed, Apr 17, 2019 at 08:41:57AM -0400, Sasha Levin wrote: >On Wed, Apr 17, 2019 at 08:28:54AM +0200, Greg KH wrote: >>On Tue, Apr 16, 2019 at 09:34:51PM -0400, Sasha Levin wrote: >>> 2. Fix to show monitor data only when monitor pages are actually >>>allocated, also by Kimberly Brown. >> >>That's not really a "fix", more like a "new feature", right? > >This is (sadly) a fix; we access invalid memory or leak kernel memory to >userspace if we access the monitor sysfs files when there are no monitor >pages allocated. > >>> drivers/hv/vmbus_drv.c | 166 +++++++++++++++++++++++++------ >>A patch this big so late in the release cycle is not good. > >Indeed, but I've had it in my queue for a few weeks now so it's been >receiving a good amount of testing - it's not something we came up with >a few days ago. > >>Can you drop this one and resend the others? If you sent this as a >>patch series, I could have done it that way on my own :) > >I would prefer if you could take it in. While it's on the bigger side, a >lot of it is documentation (and comments!), and the code itself is >straightforward and was well reviewed over 6 iterations of the original >patch. > >-- >Thanks, >Sasha
| |