lkml.org 
[lkml]   [2019]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: mvpp2: cls: Add Classification offload support
Hi David,

On Fri, 19 Apr 2019 15:09:50 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

>From: Maxime Chevallier <maxime.chevallier@bootlin.com>
>Date: Fri, 19 Apr 2019 15:30:27 +0200
>
>> +/* Internal represention of a Flow Steering rule */
>> +struct mvpp2_rfs_rule {
>> + /* Rule location inside the flow*/
>> + int loc;
>> +
>> + /* Flow type, such as TCP_V4_FLOW, IP6_FLOW, etc. */
>> + int flow_type;
>> +
>> + /* The lookup type used by this flow. This allows the classification
>> + * engines to differentiate between entries that match the same
>> + * parameters
>> + */
>> + int lu_type;
>> +
>> + /* Index of the entry handling this rule in the flow table */
>> + int flt_index;
>> +
>> + /* Index of the C2 TCAM entry handling this rule */
>> + int c2_index;
>
>On 64-bit there will be a 32-bit hole here. Why not put hek_fields
>and engine here?

You're right, I'll re-arrange that.

Thanks,

Maxime

\
 
 \ /
  Last update: 2019-04-20 12:19    [W:0.044 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site