Messages in this thread | | | Date | Tue, 2 Apr 2019 23:10:48 +0100 | From | Russell King - ARM Linux admin <> | Subject | Re: [PATCH net-next v4 1/2] net: phy: marvell10g: implement suspend/resume callbacks |
| |
On Tue, Apr 02, 2019 at 08:17:16PM +0200, Heiner Kallweit wrote: > On 02.04.2019 15:10, Antoine Tenart wrote: > > This patch adds the suspend/resume callbacks for Marvell 10G PHYs. The > > three PCS (base-t, base-r and 1000base-x) are set in low power (the PCS > > are powered down) when the PHY isn't used. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com> > > --- > > drivers/net/phy/marvell10g.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c > > index 80678919641d..9ee033c8a12b 100644 > > --- a/drivers/net/phy/marvell10g.c > > +++ b/drivers/net/phy/marvell10g.c > > @@ -51,6 +51,8 @@ enum { > > MV_AN_STAT1000 = 0x8001, /* 1000base-T status register */ > > > > /* Vendor2 MMD registers */ > > + MV_V2_PORT_CTRL = 0xf001, > > + MV_V2_PORT_CTRL_PWRDOWN = 0x0800, > > If this driver is touched again I think it would be good to change all > such constants to BIT() and GENMASK(), ideally combined with the macros > from bitfields.h. This makes it much easier to check the code against the > datasheet. Apart from that:
Specifically, which constants are you talking about?
I think there's only MV_PCS_PAIRSWAP_MASK and MV_V2_TEMP_CTRL_MASK, which would be confusing to change given that the following definitions are values for the masked field.
However, MV_V2_PORT_CTRL_PWRDOWN should be defined using BIT() in any case.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
| |