Messages in this thread | | | Subject | Re: [PATCH -next] sched/fair: Make some functions static | From | YueHaibing <> | Date | Sat, 20 Apr 2019 11:37:19 +0800 |
| |
Pls ignore this.
On 2019/3/22 22:30, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warnings: > > kernel/sched/fair.c:2596:6: warning: symbol 'task_tick_numa' was not declared. Should it be static? > kernel/sched/fair.c:3570:6: warning: symbol 'sync_entity_load_avg' was not declared. Should it be static? > kernel/sched/fair.c:3583:6: warning: symbol 'remove_entity_load_avg' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > kernel/sched/fair.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index fdab7eb..18fb781 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -2593,7 +2593,7 @@ void task_numa_work(struct callback_head *work) > /* > * Drive the periodic memory faults.. > */ > -void task_tick_numa(struct rq *rq, struct task_struct *curr) > +static void task_tick_numa(struct rq *rq, struct task_struct *curr) > { > struct callback_head *work = &curr->numa_work; > u64 period, now; > @@ -3567,7 +3567,7 @@ static inline u64 cfs_rq_last_update_time(struct cfs_rq *cfs_rq) > * Synchronize entity load avg of dequeued entity without locking > * the previous rq. > */ > -void sync_entity_load_avg(struct sched_entity *se) > +static void sync_entity_load_avg(struct sched_entity *se) > { > struct cfs_rq *cfs_rq = cfs_rq_of(se); > u64 last_update_time; > @@ -3580,7 +3580,7 @@ void sync_entity_load_avg(struct sched_entity *se) > * Task first catches up with cfs_rq, and then subtract > * itself from the cfs_rq (task must be off the queue now). > */ > -void remove_entity_load_avg(struct sched_entity *se) > +static void remove_entity_load_avg(struct sched_entity *se) > { > struct cfs_rq *cfs_rq = cfs_rq_of(se); > unsigned long flags; >
| |