lkml.org 
[lkml]   [2019]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary
On Fri, 19 Apr 2019 04:14:27 -0700 Joe Perches <joe@perches.com> wrote:

> On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote:
> > Hi Joe,
> >
> > Can you detect redundant Cc: by checkpatch?
> >
> > Please see below in details.
> > Thanks.
>
> Yes, but I'm not sure why it's useful or necessary.
> git send-email using some scripts elides duplicate email addresses

Other (all?) MUAs will avoid addressing an email to a recipient more
than once. The issue here is redundant Cc: lines in the changelog.

> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2688,6 +2688,19 @@ sub process {
> $signatures{$sig_nospace} = 1;
> }
>
> +# Check for a cc: line with another signature -by: by the same author
> + if ($sig_nospace =~ /^cc:/) {
> + my $sig_email = substr($sig_nospace, 3);
> + foreach my $sig (sort keys %signatures) {
> + next if ($sig =~ /^cc:/);
> + $sig =~ s/^[^:]+://;
> + if ($sig eq $sig_email) {
> + WARN("BAD_SIGN_OFF",
> + "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr);
> + }
> + }
> + }
> +
> # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
> if ($sign_off =~ /^co-developed-by:$/i) {
> if ($email eq $author) {

Thanks. But my checkpatch.pl is different from yours.

q:/usr/src/25> grep "immediately followed by" scripts/checkpatch.pl
q:/usr/src/25>

\
 
 \ /
  Last update: 2019-04-19 22:59    [W:0.099 / U:8.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site