lkml.org 
[lkml]   [2019]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv2] selftests/efivarfs: clean up test files from test_create*()
From
Date
On 4/19/19 7:12 AM, Po-Hsu Lin wrote:
> Test files created by test_create*() tests will stay in the
> $efivarfs_mount directory unless the system was rebooted.
>
> When the tester tries to run this efivarfs test again on the same
> system, the immutable characteristics in that directory will cause some
> "Operation not permitted" noises and a false-positve test result to the
> test_create_read() test.
>
> --------------------
> running test_create
> --------------------
> ./efivarfs.sh: line 59: /sys/firmware/efi/efivars/test_create-210be57c-9849-4fc7-a635-e6382d1aec27: Operation not permitted
> [PASS]
> --------------------
> running test_create_empty
> --------------------
> ./efivarfs.sh: line 78: /sys/firmware/efi/efivars/test_create_empty-210be57c-9849-4fc7-a635-e6382d1aec27: Operation not permitted
> [PASS]
> --------------------
> running test_create_read
> --------------------
> open(O_WRONLY): Operation not permitted
> [FAIL]
> --------------------
>
> Create a file_cleanup() to remove those test files in the end of each
> test to solve this issue.
>
> Also, use this function to replace the existing file removal code.
>
> Link: https://bugs.launchpad.net/bugs/1809704
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---

Thanks for the patch. There is another patch that does the same in
linux-kselftest next branch.

Please check to see if that fixes the problem you are seeing.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2019-04-19 20:33    [W:0.048 / U:1.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site