Messages in this thread | | | Subject | Re: [PATCH v2 1/2] power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface | From | Nandor Han <> | Date | Thu, 18 Apr 2019 09:29:08 +0300 |
| |
On 4/18/19 12:56 AM, Sebastian Reichel wrote: > On Thu, Apr 11, 2019 at 05:54:09AM +0000, Han Nandor wrote: >> Add a new reboot mode write interface that is using an NVMEM cell >> to store the reboot mode magic. >> >> Signed-off-by: Nandor Han <nandor.han@vaisala.com> >> ---
<snip>
>> +module_platform_driver(nvmem_reboot_mode_driver); >> + >> +MODULE_AUTHOR("Nandor Han <nandor.han@vaisala.com>"); >> +MODULE_DESCRIPTION("NVMEM reboot mode driver"); >> +MODULE_LICENSE("GPL v2"); > > I suppose as of bf7fbeeae6db "GPL v2" is deprecated, before it was > often read as GPL v2 only. In both cases it makes sense to just > use "GPL". Otherwise the driver looks fine to me, but I'm waiting > for Rob's review of the DT bindings before merging this. > > -- Sebastian >
Thanks Sebastian.
Do you want me to send a new revision with license changed to "GPL"?..or will you change it when it's merged?
Nandor
| |