lkml.org 
[lkml]   [2019]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESEND][PATCH v2 27/36] drivers: Add a generic helper to match device by fwnode handle
From
Date
On 04/18/2019 03:39 PM, Rafael J. Wysocki wrote:
> On Tue, Apr 16, 2019 at 12:53 PM Suzuki K Poulose
> <suzuki.poulose@arm.com> wrote:
>>
>> On 04/16/2019 11:48 AM, Rafael J. Wysocki wrote:
>>> On Tue, Apr 16, 2019 at 12:39 PM Suzuki K Poulose
>>> <suzuki.poulose@arm.com> wrote:
>>>>
>>>> Make the device_fwnode_match() a generic helper to match device
>>>> by fwnode handle for use with bus_find_device(). This will be
>>>> also used by coresight.
>>>>
>>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
>>>> Cc: linux-acpi@vger.kernel.org
>>>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>>> ---
>>>>
>>>> Resending with linux-acpi in Cc, as requested by Rafael.
>>>
>>> Do any other patches in your series depend on this one?
>>
>> Yes, I do. But they are in the middle of a big series of changes and
>> I don't expect this series to go into 5.2. So, if you plan to pull this
>> please go ahead.
>
> I would prefer the new exported function to return bool. With that
> changed, I can apply the patch I think.
>


That will need changes to all the other callers of bus_find_device()
to fix their match(). I guess that is a bit of an invasive change, so
I would rather do it in the "consolidation" series with
class_find_device().

Hope you're fine with that.

Suzuki

\
 
 \ /
  Last update: 2019-04-18 17:16    [W:0.126 / U:2.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site