lkml.org 
[lkml]   [2019]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 5/6] ext4: Search for an inode to update under the RCU lock if we can
On Thu, Apr 18, 2019 at 03:06:44PM +0100, David Howells wrote:
> + inode = find_inode_by_ino_rcu(sb, ino);
> + if (!inode)
> + return;
>
> if ((inode->i_ino != ino) ||
> (inode->i_state & (I_FREEING | I_WILL_FREE | I_NEW |
> I_DIRTY_INODE)) ||
> ((inode->i_state & I_DIRTY_TIME) == 0))

Umm... The situation with memory barriers here needs to be documented,
IMO. And I'm not sure if the thing is actually correct...

\
 
 \ /
  Last update: 2019-04-18 17:09    [W:0.086 / U:4.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site