lkml.org 
[lkml]   [2019]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 4/5] signal: support CLONE_PIDFD with pidfd_send_signal
From
On April 18, 2019 4:26:00 PM GMT+02:00, Oleg Nesterov <oleg@redhat.com> wrote:
>On 04/18, Christian Brauner wrote:
>>
>> +static struct pid *pidfd_to_pid(const struct file *file)
>> +{
>> + if (file->f_op == &pidfd_fops)
>> + return file->private_data;
>> +
>> + return tgid_pidfd_to_pid(file);
>> +}
>
>the patch looks obviously fine to me, but I have an absolutely
>off-topic
>question... why tgid_pidfd_to_pid() has to check d_is_dir() ?

It doesn't have too; pure paranoia.

Christian

\
 
 \ /
  Last update: 2019-04-18 17:01    [W:0.043 / U:2.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site