lkml.org 
[lkml]   [2019]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] asm/io: Correct output operand specification of the MMIO write* routines
Hi,

On Wed, 17 Apr 2019, Linus Torvalds wrote:

> So I see no upside to changing it.

As long as the memory clobber stays (and it can't be removed in the
general case, as you say) the change has no practical effect.

<outsider>
It does have a psychological upside, though: people won't continue to
wonder why the asm doesn't precisely specify what it does, and instead
only declares a memory-read while clearly being a memory write.
Normally, with asms, leaving nothing to wonder about is a good thing.
</outsider>


Ciao,
Michael.

\
 
 \ /
  Last update: 2019-04-18 14:17    [W:0.053 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site