lkml.org 
[lkml]   [2019]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary
On Wed, 17 Apr 2019 15:37:49 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> > It's pretty benign: Doug will still only get a single email.
> >
> >
> > checkpatch checks for duplicates cc's but I think it assumes that
> > things like
> >
> > Reported-by: fred
> > Tested-by: fred
> >
> > were intentional.
> >
> > It would perhaps be better for checkpatch to special-case the "Cc:
> > fred" tag and report a duplicated Cc: if fred was also mentioned in any
> > other tag.
>
> Sorry, I do not understand what you mean.
>
>
> Douglas did not add any Cc: tag at all
> in his original patch:
> https://lore.kernel.org/patchwork/patch/1053953/
>
>
> It's you who added the Cc: tags
> (and I am guessing you did it by scripting.)
>
> Why is this topic related to checkpatch?

Because I regularly check all patches with checkpatch but checkpatch
failed to detect that I had

Signed-off-by: Douglas Anderson <dianders@chromium.org>
...
Cc: Douglas Anderson <dianders@chromium.org>

and I believe that checkpatch could and should have warned about this
situation.

\
 
 \ /
  Last update: 2019-04-19 01:08    [W:0.061 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site