lkml.org 
[lkml]   [2019]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] stmmac: pci: Adjust IOT2000 matching
From
From: Jan Kiszka <jan.kiszka@siemens.com>
Date: Thu, 18 Apr 2019 20:24:28 +0200

> On 18.04.19 19:43, David Miller wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>> Date: Thu, 18 Apr 2019 11:14:56 +0200
>>
>>> @@ -170,8 +176,6 @@ static const struct dmi_system_id quark_pci_dmi[]
>>> = {
>>> {
>>> .matches = {
>>> DMI_EXACT_MATCH(DMI_BOARD_NAME, "SIMATIC IOT2000"),
>>> - DMI_EXACT_MATCH(DMI_BOARD_ASSET_TAG,
>>> - "6ES7647-0AA00-1YA2"),
>>> },
>>> .driver_data = (void *)&iot2040_stmmac_dmi_data,
>> So really, every IOT2000 that doesn't have the IOT2020 asset tag will
>> be
>> a 2040? Forever?
>>
>
> Yes, seriously. The next version won't have all that DMI and ACPI
> stuff. And if there will ever be a version with that again, it will
> not be labeled "IOT2000" via the board name entry. And it will have
> more robust hardware discovery as well. Lesson(s) learned, in fact not
> only for this product series.

Ok, applied, thanks.

\
 
 \ /
  Last update: 2019-04-18 20:49    [W:0.047 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site